Moon Phases (Spot), Correctness Audit

Audit / Issue Found

A deep review of every variable in this lunar-cycle strategy turned up one real bug in the user-facing notification.

Before the patch

When the second take-profit was hit the notification that gets sent out included the percentage from the third take-profit instead of the percentage from the second. So if your take-profit two is set to three percent and your take-profit three is set to five point five percent, hitting take-profit two would tell you a plus five point five percent gain even though the actual sell happened at the three percent level.

After the patch

The notification now reads the take-profit two percentage, matching the price at which the sell actually executed.

Other findings from the review were checked. The futures sibling of this strategy was already using the correct percentage. The grid-entry price tracking was reviewed and noted as an area for future improvement, but it does not affect trading decisions today since the break-even is taken from the exchange.

Bottom line

The take-profit two notification now reports the correct number, so the trade summaries you receive match what really happened.